SWIFT-639 Update Kitura example #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
force-pushed
the
kitura-example
branch
from
78be86d to
84961d5
Compare
Contributor
Author
|
Ready for review now that |
patrickfreed
approved these changes
Feb 21, 2020
Contributor
patrickfreed
left a comment
patrickfreed
left a comment
There was a problem hiding this comment.
lgtm mod the Package.swift version
kmahar
added a commit
that referenced
this pull request
Feb 21, 2020
kmahar
added a commit
that referenced
this pull request
Feb 26, 2020
kmahar
added a commit
that referenced
this pull request
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another draft PR for similar reasons to those described in #398 (excluding the concerns about using a beta version of the framework.)